Re: [hurd,commited] hurd TIOCFLUSH: Cope BSD 4.1 semantic

[Andreas Schwab]

On Feb 01 2021, Samuel Thibault wrote:

> BSD 4.1 did not have an argument for TIOCFLUSH, BSD 4.2 added it. There
> are still a lot of applications out there that pass a NULL argument to
> TIOCFLUSH, so we should rather cope with it.
> ---
>  sysdeps/mach/hurd/ioctl.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/sysdeps/mach/hurd/ioctl.c b/sysdeps/mach/hurd/ioctl.c
> index 662e8ee919..0d5bc176d1 100644
> --- a/sysdeps/mach/hurd/ioctl.c
> +++ b/sysdeps/mach/hurd/ioctl.c
> @@ -113,6 +113,10 @@ __ioctl (int fd, unsigned long int request, ...)
>         /* We don't want to advance ARG since it will be used to copy out
>            too if IOC_OUT is also set.  */
>         void *argptr = arg;
> +       int zero = 0;
> +
> +       if (request == TIOCFLUSH && !arg)
> +         arg = &zero;

s/arg/argptr/.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."