[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[hurd] 38/87: trans/fakeroot: fix error handling
From: |
Samuel Thibault |
Subject: |
[hurd] 38/87: trans/fakeroot: fix error handling |
Date: |
Sun, 09 Nov 2014 11:05:02 +0000 |
This is an automated email from the git hooks/post-receive script.
sthibault pushed a commit to branch upstream
in repository hurd.
commit 470972f3f854e92ee1cc8f1e2ada8412a2b97956
Author: Justus Winter <address@hidden>
Date: Mon Jun 16 16:50:12 2014 +0200
trans/fakeroot: fix error handling
Found using the Clang Static Analyzer.
* trans/fakeroot.c (new_node): Do not leak a pointer to freed memory.
Store NULL at *np instead. This fixes a node use-after-free in
netfs_S_dir_lookup.
---
trans/fakeroot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/trans/fakeroot.c b/trans/fakeroot.c
index 32a34ec..df2de64 100644
--- a/trans/fakeroot.c
+++ b/trans/fakeroot.c
@@ -119,6 +119,7 @@ new_node (file_t file, mach_port_t idport, int locked, int
openmodes,
mach_port_deallocate (mach_task_self (), nn->idport);
mach_port_deallocate (mach_task_self (), file);
free (*np);
+ *np = NULL;
return err;
}
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/pkg-hurd/hurd.git
- [hurd] 14/87: Merge branch 'random' of ssh://git.savannah.gnu.org/srv/git/hurd/incubator into random, (continued)
- [hurd] 14/87: Merge branch 'random' of ssh://git.savannah.gnu.org/srv/git/hurd/incubator into random, Samuel Thibault, 2014/11/09
- [hurd] 28/87: term: improve the demuxer, Samuel Thibault, 2014/11/09
- [hurd] 27/87: Add the random translator to prog-subdirs, Samuel Thibault, 2014/11/09
- [hurd] 33/87: Merge procfs into the Hurd repository, Samuel Thibault, 2014/11/09
- [hurd] 34/87: Add the procfs translator to prog-subdirs, Samuel Thibault, 2014/11/09
- [hurd] 36/87: ftpfs: fix error handling in refresh_dir, Samuel Thibault, 2014/11/09
- [hurd] 29/87: hurd: fix receiver lookup in termctty_open_terminal, Samuel Thibault, 2014/11/09
- [hurd] 35/87: Add mach_debug defs rules, Samuel Thibault, 2014/11/09
- [hurd] 37/87: libshouldbeinlibc: fix dead initialization in fmt_named_interval, Samuel Thibault, 2014/11/09
- [hurd] 32/87: Prepare the procfs translator to be merged into the Hurd sources, Samuel Thibault, 2014/11/09
- [hurd] 38/87: trans/fakeroot: fix error handling,
Samuel Thibault <=
- [hurd] 39/87: libports: avoid realloc(3) corner case, Samuel Thibault, 2014/11/09
- [hurd] 40/87: libdiskfs: add permission check to file_chflags, Samuel Thibault, 2014/11/09
- [hurd] 31/87: Merge branch 'merge-random', Samuel Thibault, 2014/11/09
- [hurd] 41/87: libdiskfs: expose the ST_NOATIME flag, Samuel Thibault, 2014/11/09
- [hurd] 43/87: ext2fs: use correct type for block numbers, Samuel Thibault, 2014/11/09
- [hurd] 42/87: libdiskfs: fix deadlock, Samuel Thibault, 2014/11/09
- [hurd] 44/87: libpipe: fix calls to pipe_send with no data, Samuel Thibault, 2014/11/09
- [hurd] 24/87: ext2fs: fix type of retry_dotdot, Samuel Thibault, 2014/11/09
- [hurd] 23/87: ext2fs: fix type of blockaddr, Samuel Thibault, 2014/11/09
- [hurd] 30/87: utils/settrans: implement settrans --start, Samuel Thibault, 2014/11/09