[Commit-gnuradio] [gnuradio] 03/08: grc: not all tooltips in block library were updated after docstring extraction finished

[git]

This is an automated email from the git hooks/post-receive script.

jcorgan pushed a commit to branch maint
in repository gnuradio.

commit 1025df04816539bc8d11ae29a6e3a10c200ada9b
Author: Sebastian Koslowski <address@hidden>
Date:   Fri Feb 5 11:49:47 2016 +0100

    grc: not all tooltips in block library were updated after docstring 
extraction finished
---
 grc/gui/BlockTreeWindow.py | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/grc/gui/BlockTreeWindow.py b/grc/gui/BlockTreeWindow.py
index 792d280..6b3ebf7 100644
--- a/grc/gui/BlockTreeWindow.py
+++ b/grc/gui/BlockTreeWindow.py
@@ -152,20 +152,17 @@ class BlockTreeWindow(gtk.VBox):
 
     def update_docs(self):
         """Update the documentation column of every block"""
-        def update(node):
-            for i in range(treestore.iter_n_children(node) or 0):
-                update(treestore.iter_nth_child(node, i))
-
-            if not treestore.iter_has_child(node):
-                key = treestore.get_value(node, KEY_INDEX)
-                block = self.platform.get_block(key)
-                doc = Utils.parse_template(DOC_MARKUP_TMPL, 
doc=block.get_doc())
-                treestore.set_value(node, DOC_INDEX, doc)
-
-        for treestore in self.treestore, self.treestore_search:
-            root = treestore.get_iter_root()
-            if root:
-                update(root)
+
+        def update_doc(model, _, iter_):
+            if model.iter_has_child(iter_):
+                return  # category node, no doc string
+            key = model.get_value(iter_, KEY_INDEX)
+            block = self.platform.get_block(key)
+            doc = Utils.parse_template(DOC_MARKUP_TMPL, doc=block.get_doc())
+            model.set_value(iter_, DOC_INDEX, doc)
+
+        self.treestore.foreach(update_doc)
+        self.treestore_search.foreach(update_doc)
 
     ############################################################
     ## Helper Methods