[commit-cp] [bugs #11970] faulty Kaffe check in gjdoc/m4/ac_prog_jar.m4

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11970>

                 Summary: faulty Kaffe check in gjdoc/m4/ac_prog_jar.m4
                 Project: classpath
            Submitted by: None
            Submitted on: Sun 02/13/2005 at 18:57
                Category: gjdoc
                Severity: 5 - Average
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
        Platform Version: None

    _______________________________________________________

Details:

gjdoc/m4/ac_prog_jar.m4 in CVS contains the following check:

grep kaffe\.tools\.jar\.Jar $JAR >/dev/null || \
  AC_MSG_WARN([The build seems to be using the Jar tool that comes with
Kaffe. Note that there are known issues in some versions of this tool.
If you see error messages from the Jar tool, or the build hangs,
please set environment variable JAR to a working Jar tool.])

There are three bugs in this:

* If $JAR is e.g. "jar" and does not contain any slashes, then grep
  will try to open it from the working directory, instead of scanning
  the $PATH.

* If grep finds the "kaffe.tools.jar.Jar" text in the file, then it
  exits with code 0 meaning success, and the "||" operator then causes
  the warning to be omitted.  This could be fixed by changing the
  operator to "&&", but I think it would be clearer to use "if".

* The backslashes in kaffe\.tools\.jar\.Jar do not have any effect,
  because the shell consumes them; thus each "." matches any
  character.  This could be fixed by enclosing the whole string in
  single or double quotes.







    _______________________________________________________

This item URL is:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11970>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/