commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libclasspath const/non-const warnings (was: Re: fix const/non-const


From: Michael Koch
Subject: Re: libclasspath const/non-const warnings (was: Re: fix const/non-const warnings in jcl.c, jcl.h)
Date: Mon, 21 Jun 2004 22:05:47 +0200
User-agent: KMail/1.6.2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Montag, 21. Juni 2004 21:29 schrieb Steven Augart:

A little nitpick:

> -JCL_free_cstring (JNIEnv * env, jstring s, const char *cstr)
> +JCL_free_cstring (JNIEnv * env, jstring s, char *cstr)
>  {
>    (*env)->ReleaseStringUTFChars (env, s, cstr);
>  }

I would think "cstr" stands for "constant string" but you removed 
"const". Perhaps you should rename "cstr" to "str".


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA1z+bWSOgCCdjSDsRAslIAKCeYn1WTknxGMg6SiVglSwhPgP0MgCgi5rK
rApuzNRmxRQh+XhtRKRThgg=
=Pqot
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]