Re: [cp-patches] Proposed patch: BasicSliderUI/MetalSliderUI

[David Gilbert]

Roman Kennke wrote:

> Hi,
>
>> I've done some work on the BasicSliderUI class and an implementation of
>> MetalSliderUI (see attached screenshot).
>>
>
> Looks nice! Thank you.
>
>>  This is now working reasonably
>> well, although it is not 100% complete.  Due to time
>> constraints/holidays, I may have to leave this for a few weeks - my
>> question is whether the attached patch should be committed to CVS.  I
>> think it is an improvement to the existing code, so it should go in,
>> even though it still requires work.  Any comments?
>>  
>>
>
> Check it in. If there are problems, others (like me) can still fix it.
> It surely is an improvement (the slider was almost unusable before).
>
>> A couple of hints about the changes:
>>
>> (1)  I deleted thumbHeight, thumbWidth, and tickHeight because they were
>> all initialised from values in the UIDefaults that don't exist in Sun's
>> implementation.  Instead, constants are now used - other lafs can change
>> these by overriding methods like getThumbSize().
>>  
>>
>
> Ok.
>
>> (2)  I implemented the MetalSliderUI on top of Sun's BasicSliderUI, and
>> from testing it seems that the incoming Graphics in the tick painting
>> methods already has a translation applied to it.  I added the same
>> translation to Classpath's BasicSliderUI to make my MetalSliderUI code
>> work the same on both platforms.
>>  
>>
>
> I think this fine.
>
> Please commit this.
>
> /Roman
>
>
OK.  Committed.

Regards,

Dave