[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Request for review
From: |
Arnaud Bailly |
Subject: |
Re: Request for review |
Date: |
Fri, 14 May 2021 22:50:20 +0200 |
--
Arnaud Bailly - @dr_c0d3
On Fri, May 14, 2021 at 10:27 PM Vasilij Schneidermann <mail@vasilij.de> wrote:
>
>
> I'd generally recommend studying Riastradh's style guide [1]_.
Thanks for the pointer!
>
> - Why bind variables with let, then immediately set! them? For
> side-effectful values I'd just use let* with the corresponding
> expression.
Indeed!
> - Consider doing some basic encapsulation by writing
> constructor/accessor procedures, that makes swapping out the
> implementation a lot easier. SICP has a bunch of things to say on the
> topic.
I have read it quite a while ago :) But I guess it's time for a second look.
Thanks a lot for your feedback!
Arnaud