[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][memory-mapped-files] Allow memory mapping files bigger than
From: |
felix . winkelmann |
Subject: |
Re: [PATCH][memory-mapped-files] Allow memory mapping files bigger thanMAX_INT |
Date: |
Sun, 15 Dec 2024 18:31:04 +0100 |
> I hope I'm sending this to the right address, cc'ing Peter Bex
> because he's mentioned in the .egg definition.
Yes, this is the right place.
> The `memory-mapped-files` egg currently treats the `length` and
> `offset` parameters of `mmap` as integers which arbitrarily
> restricts mapable files to a size of MAX_INT bytes.
>
> By simply changing the type declaration in the `foreign-lambda`
> definitions we can allow basically arbitrarily big files to be
> mapped.
>
> Ultimately I'm looking to also patch the `simple-md5` egg to be
> able to hash arbitrarily big files. Currently it has the same
> restriction.
>
> Caveats:
> 1. I have no insight if this was a deliberate restriction that
> works around some issue I'm not aware of.
> 2. I'm not able to test the code for any platform but linux.
>
>
> I have basically no experience with svn, I hope I got the patch
> format right, let me know if not.
That's perfect - thanks a lot, I will apply the patch. If you have more of
this, keep 'em coming.
cheers,
felix