chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix decompose-directory and change drives before attempting to b


From: Peter Bex
Subject: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows
Date: Sat, 9 Nov 2019 17:15:14 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

Hi all,

I had a look at #1647 and the fix seems to me to be pretty
straightforward.  The build.bat which chicken-install creates
contains a "cd" command, but on Windows, cd won't change to
the corresponding drive, so when we then try to compile the
source file, we'll get an error because we're still on the other
drive.

The fix is to first switch drives, then run cd.

While working on this, I discovered that decompose-directory crashes
on Windows when the path has a drive in it, so the first patch first
fixes that bug, the second patch actually fixes the bug from the ticket.

BTW, I find decompose-directory a bit awkward when all I want is the
drive letter.  I thought about adding the drive letter to
decompose-pathname but that would be a breaking change.

It would be nice to have pathname-drive and pathname-replace-drive
procedures, but that's weird and inconsistent if decompose-pathname
doesn't yield the drive letter.  So for now I think the patch is fine
as it is.  It's still a bit awkward though.

Cheers,
Peter

Attachment: 0001-Fix-crash-in-decompose-directory-on-Windows.patch
Description: Text Data

Attachment: 0002-Change-to-the-drive-before-changing-directory-when-r.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]