[Ccrtp-devel] Bugs in control.cpp

[Jonas Lundberg]

Hi ccRTP developers,

I've found some bugs in the control.cpp file which I would like to share with you

- In QueueRTCPManager::setPRIVPrefix use "delete [] buf" when deallocating memory

- The timercmp macro doesn't seem to work on Windows for '>=' or '<=',  (at least not on W2k).

- In QueueRTCPManager::packSDES pkt->fh.length is calculated as htons((len - prevlen - 1) >>2), I think htons(((len - prevlen)>>2) - 1) is correct

- In QueueRTCPManager::takeInControlPacket()  onGotAPP is called like this: onGotAPP(*s,pkt->info.APP,pkt->getLength()); It would be more consistent if the length was specified without the first four bytes included. This is how it works for SR and RR. I.e. use onGotAPP(*s,pkt->info.APP,pkt->getLength()-4); instead.

BR Jonas