Re: [Bug-xorriso] libisofs fails out-of-tree

[Burton, Ross]

I've a number of local cleanups.  I went the low-impact route of not
moving version.h but your approach to move it alongside the other
headers is better.

I was going to push a branch to your gitlab instance but it doesn't
allow registration, so I've a fork on my personal gitlab.com account:

https://gitlab.com/rossburton/libisofs/commits/outoftree

The commit messages need cleaning up, and the bulk of those patches
apply to libburn / libisofs / libisoburn.  Doing a 'make distcheck'
periodically, and definitely instead of just 'make dist' as part of
the release, is a good way to be sure the builds continue to work.

Ross


On Thu, 4 Apr 2019 at 22:06, Thomas Schmitt <address@hidden> wrote:
>
> Hi,
>
> > As version.h is being written to the top of the build dir, add that to
> > the include search path. Something like:
> > AM_CPPFLAGS = "-I $(top_builddir)"
>
> Ah, yes.
> But it looks like "-quotes and blank after -I are incompatible.
> This works:
>
>   AM_CPPFLAGS = -I $(top_builddir)/libisofs
>
> I have to dive in one directory deeper because the source has
>
>   #include "../version.h"
>
> (Meanwhile i learned how i could redirect version.h to libisofs/ by
>  AC_CONFIG_FILES. And i remember that i had a dispute with the original
>  developer of libisofs about the wisdom of letting the build system
>  define the source version. So libburn and libisoburn have their versions
>  in the source, not in autotools files.)
>
> -------------------------------------------------------------------------
>
> Next i tried to solve the demo/demo problem by adding another -I
>
>   AM_CPPFLAGS = -I $(top_builddir)/libisofs -I $(top_srcdir)/libisofs
>
> but had to learn that the difference between library and demo is obviously
> the existence of
>
>   demo_demo_CPPFLAGS = -Ilibisofs
>
> So i clarified it by
>
>   demo_demo_CPPFLAGS = -I $(top_srcdir)/libisofs
>
> Whew. "make" now runs up to the end.
>
> -------------------------------------------------------------------------
>
> I will test libisoburn tomorrow and also work on your other requests.
> For now: Thanks a lot for guiding me.
>
>
> Have a nice day :)
>
> Thomas
>