Re: [Bug-xorriso] Test Proposal for [bug #46716] Protective MBR partition is not marked as bootable

[Alexander E. Patrakov]

20.12.2015 19:07, Thomas Schmitt пишет:
> Hi,
>
> xorriso wrote under my insufficient control:
> > >     MBR partition      :   1   0x80  0xee            1        32803
>
> Alexander E. Patrakov wrote:
> > OK, this is the bug. You have a 0xee partition, that indicates that GPT
>
> Yep. Looks like a xorriso bug.
> (How could this slip through when i looked at it ?)
>
> -----------------------------------------------------------------
> The presence of HFS+ lets it expect GPT and thus causes type 0xee
> for the first partition.
> Else it would have put out 0x83 or 0xcd.
> Poorly tested in other situations because grub-mkrescue is my
> only HFS+ user and is eager to really produce GPT.
> -----------------------------------------------------------------
>
> I was too lazy to check again after i added the -hfsplus options
> in the second mail.
> I now tested that my first proposal would have worked with OVMF
> and would then have failed if HFS+ had been produced in later runs.
> In that first mail of today, the resulting partition type was 0x83.
>
> Shall i count this as good luck or as bad luck ?



> A pebkac error was to omit xorriso command -hfsplus "on"
> before letting the option proposer work.
>
>    $ xorriso -hfsplus on -indev minimal-grub2.iso \
>              -report_el_torito as_mkisofs
>
> correctly proposes
>
>    -hfsplus-file-creator-type chrp tbxj 
> '/System/Library/CoreServices/.disk_label'
>    -hfs-bless-by intel_bootfile '/System/Library/CoreServices/boot.efi'
>
> Please add these options if you make further tests with
> option -hfsplus enabled.
> (Patching for now: boot flag in partition 1, type 0x83 in partition 1.)

I will be too far from the Intel DG965SS board for the rest of the day, 
so please expect the test results tomorrow. Sorry!

> > Unfortunately, fdisk does not allow me to replicate
> > your desired partition tables exactly. I did want to swap partitions, but
> > couldn't.
>
> After i saw your dd operations i thought that you could do it
> that way. :))

Ah, yes :) will do that tomorrow. So, please assume that I can copy and 
swap partitions, can set and unset the bootable flag, and can change the 
type of each partition, but cannot change start and end.

> > Here is the layout that I have tested:
> > ...
> > MBR partition      :   1   0x80  0x00            1        32803
>
> There is no need for type 0x00 here. We'd only need it for a
> MBR partition which EFI shall ignore as much as possible, if we
> decide to violate the no-overlaps prescription.

I agree.

--
Alexander E. Patrakov