bug-xnee
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #58810] Do not unintentionally declare enum variables (unbreak the


From: Peter Pentchev
Subject: [bug #58810] Do not unintentionally declare enum variables (unbreak the build with GCC 10)
Date: Thu, 23 Jul 2020 03:15:41 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

URL:
  <https://savannah.gnu.org/bugs/?58810>

                 Summary: Do not unintentionally declare enum variables
(unbreak the build with GCC 10)
                 Project: Xnee
            Submitted by: ppentchev
            Submitted on: Thu 23 Jul 2020 07:15:39 AM UTC
                Category: libxnee
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hi,

First of all, thanks for writing and maintaining the Xnee suite!

What do you think about the attached patch that corrects the declaration of
enumerated types so that they do not accidentally define variables of the
corresponding type?

To be honest, I was not sure whether the double naming was because of an
intention to declare typedefs for all these enums or out of routine. If the
intention was to create typedefs, I can rework my patch to do that instead;
however, since none of these types are actually used, I was not certain which
way to go and chose the one with the least number of declarations.

Thanks again, and keep up the great work!

G'luck,
Peter




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 23 Jul 2020 07:15:39 AM UTC  Name: enum-decl.patch  Size: 4KiB   By:
ppentchev

<http://savannah.gnu.org/bugs/download.php?file_id=49534>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58810>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]