[Bug-XBoard] [bug #37210] Mishandling of X11 -I flags

[Daniel Macks]

URL:
  <http://savannah.gnu.org/bugs/?37210>

                 Summary: Mishandling of X11 -I flags
                 Project: XBoard
            Submitted by: dmacks
            Submitted on: Tue 28 Aug 2012 03:31:19 PM GMT
                Category: XBoard (X11)
                Severity: 3 - Normal
              Item Group: Installation/Configuration/Packaging
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: None

    _______________________________________________________

Details:

A fink user reported that building xboard on OS X 10.8 failed to find the Xt
headers. Apple (or XQuartz, not sure how far up the vendor tree this goes)
formerly supplied a /usr/include/X11 -> /usr/X11 symlink but no longer does.
As a result, AC_CHECK_HEADER no longer finds x11 headers because they are not
in the default search paths. The standard x11 detection mechanism succeeds and
finds the needed additional -I flags, but then configure.ac does not use them
when doing its own tests.

Here is the good way (from xboard-4.5.2a line 350):

  save_cflags="$CFLAGS"
  CFLAGS="$CFLAGS $X_CFLAGS"
  CPPFLAGS="$CPPFLAGS $X_CFLAGS"
  AC_CHECK_HEADERS(X11/xpm.h)
  CFLAGS="$save_cflags"

(though it probably should save and restore CPPFLAGS also?)

Lines 128 and 154 each fail because they don't propagate X_CFLAGS.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 28 Aug 2012 03:31:19 PM GMT  Name: x11-flag-propagation.patch  Size:
1kB   By: dmacks

<http://savannah.gnu.org/bugs/download.php?file_id=26437>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37210>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/