[Bug-XBoard] Infinite recursion

[Byrial Jensen]

I see something strange with the current git master code.

My .xboard contains these lines:

-recentEngines 4
-recentEngineList {stockfish
fairymax
}
-firstChessProgramNames {fairymax
"Fruit 2.1" -fcp fruit -fUCI
"Crafty" -fcp crafty
"GNU Chess" -fcp gnuchess
"stockfish" -fd "." -fUCI
}

Fairymax is not installed.

If I start xboard in the C locale (no localization) it will pop up an 
error window with "Failed to start first chess engine fairymax on 
localhost: fairymax: No such file or directory". And in the engine menu 
the items for settings for engine #1 and #2 are not enabled.

However if start xboard in my normal Danish locale the error error does 
not come up, and the engine setting menu item are enabled. If I click on 
"Engine #1 settings", xboard will crash.

The bottom of the very, very log stack trace is:

#16891 0x080b0801 in ErrorPopUp (title=0xb733ea3f <Address 0xb733ea3f 
out of bounds>,
    label=0xb733d715 <Address 0xb733d715 out of bounds>, modal=0) at 
dialogs.c:1681
#16892 0x080b0bb8 in DisplayNote (message=0xb733d715 <Address 0xb733d715 
out of bounds>) at dialogs.c:1754
#16893 0x080a9644 in GenericPopUp (option=0x81b9520, title=0xb733ea3f 
<Address 0xb733ea3f out of bounds>,
    dlgNr=ErrorDlg, parent=BoardWindow, modal=0, top=0) at xoptions.c:747
#16894 0x080b0801 in ErrorPopUp (title=0xb733ea3f <Address 0xb733ea3f 
out of bounds>,
    label=0xb733d715 <Address 0xb733d715 out of bounds>, modal=0) at 
dialogs.c:1681
#16895 0x080b0bb8 in DisplayNote (message=0xb733d715 <Address 0xb733d715 
out of bounds>) at dialogs.c:1754
#16896 0x080a9644 in GenericPopUp (option=0x82e4c30, title=0xb733d6f7 
<Address 0xb733d6f7 out of bounds>,
    dlgNr=TransientDlg, parent=BoardWindow, modal=1, top=0) at 
xoptions.c:747
#16897 0x080af3d9 in SettingsPopUp (cps=0x82e4560) at dialogs.c:1177
#16898 0x080af3ed in FirstSettingsProc () at dialogs.c:1183
#16899 0x080b1000 in MenuCallback (n=6) at dialogs.c:1897
#16900 0x080a80f7 in ComboSelect (w=0x960d558, addr=0xf060003 <Address 
0xf060003 out of bounds>, index=0x0)
    at xoptions.c:332
#16901 0xb75637f1 in XtCallCallbacks () from 
/usr/lib/i386-linux-gnu/libXt.so.6
#16902 0xb77414b2 in ?? () from /usr/lib/i386-linux-gnu/libXaw.so.7
#16903 0xb7740928 in ?? () from /usr/lib/i386-linux-gnu/libXaw.so.7
#16904 0xb7599f4f in ?? () from /usr/lib/i386-linux-gnu/libXt.so.6
#16905 0xb759a363 in ?? () from /usr/lib/i386-linux-gnu/libXt.so.6
#16906 0xb759b0ae in _XtTranslateEvent () from 
/usr/lib/i386-linux-gnu/libXt.so.6
#16907 0xb75722cc in XtDispatchEventToWidget () from 
/usr/lib/i386-linux-gnu/libXt.so.6
#16908 0xb7572a17 in ?? () from /usr/lib/i386-linux-gnu/libXt.so.6
#16909 0xb7572b7a in XtDispatchEvent () from 
/usr/lib/i386-linux-gnu/libXt.so.6
#16910 0xb7573014 in XtAppMainLoop () from 
/usr/lib/i386-linux-gnu/libXt.so.6
#16911 0x08097b84 in main (argc=1, argv=0xbfab6d64) at xboard.c:1519

The rest is DisplayNote() calling ErrorPopUp() calling GenericPopUp() 
calling DisplayNote() etc. until the stack is full.

But the point is that the behavoir depends on the locale in a way it 
shouldn't.