bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re[2]: Add --custom-html-attrs option to support custom HTML tags and at


From: Lyubomyr Shaydariv
Subject: Re[2]: Add --custom-html-attrs option to support custom HTML tags and attributes
Date: Thu, 23 Jan 2020 22:55:22 +0200

Hi Darshit,

Apologies for my previous email formatting: it got broken.

Yes, I was thinking of using the --follow-tags switch that
also was suggested in the "HTML Parsing" thread (Sep 2014),
but as far as I understand how it works in html-url.c, it
builds an intersection between the list of built-in HTML
tags and the tags the user wants to follow, so it cannot
be used to register new tags and attributes. This is why
I considered adding a new switch.


23 січня 2020, 19:39:04, від "Darshit Shah" <address@hidden>:

> Hi Lyubomyr,
> 
> Thanks for your patch!
> 
> I haven't tested it yet, but I wonder why the existing switch
> `--follow-tags=LIST` was not enough for your use case. IIRC, it was
> exactly this case that it was implemented for.
> 
> * Lyubomyr Shaydariv <address@hidden> [200123 18:35]:
> > Hi,
> > 
> > Some HTML documents use non-standard attributes that are essentially URLs 
> > that might be walked through. The attached patch allows to specify new tags 
> > and attributes to follow.
> > 
> > Example of use:
> > 
> > ./wget -nd -r -P . -A jpg \
> >     --custom-html-attrs=div/big_img,div/med_img \
> >     http://localhost/index.html
> > 
> > However:
> > The patch does not include tests or external documentation updates of any 
> > kind. It does not validate tag/attribute pairs except of simple "/" 
> > checking. 
> > I'm not a C programmer, so I'm fine if the patch is considered poor and 
> > consequently rejected.
> > Thanks.
> 
> 
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]