[Bug-wget] [bug #50223] wget 1.19 will not build on MacOS 10.12.3

[Zhiming Wang]

Follow-up Comment #16, bug #50223 (project wget):

Thanks, removing the test "X$iri" = "Xno" branch does fix the problem.

Now that compilation succeeds, I ran make check to make sure everything's
working, and insterestingly, whether I configure with --disable-iri or not,
there's one single test failure: Test-iri-disabled.px. I'm attaching the log
for this test. Looks like wget insists on percent encoding the filenames,
despite the "blah blah saved" showing the raw unencoded filenames.

By the way, I also noticed a small problem in tests/WgetTests.pm's error
message. Here's a patch to fix it


diff --git a/tests/WgetTests.pm b/tests/WgetTests.pm
index 34253b1..4d32813 100644
--- a/tests/WgetTests.pm
+++ b/tests/WgetTests.pm
@@ -359,8 +359,8 @@ sub _verify_download
               );
     if (@unexpected_downloads)
     {
-        return 'Test failed: unexpected downloaded files [' . join ', ',
-          @unexpected_downloads . "]\n";
+        return 'Test failed: unexpected downloaded files [' .
+          (join ', ', @unexpected_downloads) . "]\n";
     }
 
     return q{};


As you can see, without the patch (which puts parentheses around the join),
@unexpected_downloads is treated in a scalar context and join ', ' does
nothing, resulting in messages like


Test failed: unexpected downloaded files [3]


instead of the presumably intended


Test failed: unexpected downloaded files [p1_fran%E7ais.html, p2_%E9%E9n.html,
p3_%A4%A4%A4.html]


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50223>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/