Re: [Bug-wget] [PATCH 12/25] New test: --continue shall keep fully retrieved Metalink files (HTTP 416)

[Giuseppe Scrivano]

Hi Matthew,

Matthew White <address@hidden> writes:

> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, 
> contrib/check-hard is ok]
>
> This introduces a new Metalink test to verify that when --continue is used, 
> after a HTTP 416 answer a file that fails a sanity test isn't renamed/removed.
>
> The following description is verbatim from the patch:
> -----
> Ensure that --continue doesn't rename/remove existing and/or fully
> retrieved files which fail the sanity tests.
> -----

can this test be included together with the patch that introduces this change?

> +MetaXml = re.sub (r'{{FILE1_HASH}}', File1_sha256, MetaXml)
> +MetaXml = re.sub (r'{{FILE2_HASH}}', File2_sha256, MetaXml)
> +MetaXml = re.sub (r'{{FILE3_HASH}}', File3_sha256, MetaXml)
> +MetaXml = re.sub (r'{{FILE4_HASH}}', File4_sha256, MetaXml)
> +MetaXml = re.sub (r'{{FILE5_HASH}}', File5_sha256, MetaXml)
> +MetaXml = re.sub (r'{{SRV_HOST}}', srv_host, MetaXml)
> +MetaXml = re.sub (r'{{SRV_PORT}}', str (srv_port), MetaXml)
> +MetaFile.content = MetaXml

would just MetaXml.replace be enough here as well?

Thanks,
Giuseppe