Re: [Bug-wget] [PATCH v2] wget: Add --use-askpass support

[Steven Schubiger]

For what it is worth,

Liam R. Howlett <address@hidden> wrote:
> +void
> +run_use_askpass(char *question, char **answer)

Use a space between the function name and opening parenthesis.

> +  char * const argv[] = {question, NULL};

Ideally a space after opening and before closing brace.

> +  if (pipe(com) == -1)

Insert a space between function name and opening parenthesis.

> +  {
> +    fprintf(stderr, _("Cannot create pipe"));
> +    exit (WGET_EXIT_GENERIC_ERROR);
> +  }

Indent both braces with two spaces.

Ideally :-), this "should" be also applied to the rest of the patch
to be generally consistent with the remaining code.

Of course, correct me if I'm wrong.

-- 
The truth may be out there,
but lies are inside your head.
    -- Terry Pratchett