Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support

[Liam R. Howlett]

* Liam R. Howlett <address@hidden> [160725 10:06]:
> * ?ngel Gonz?lez <address@hidden> [160724 13:15]:
> > I don't think the name --ssh-askpass is appropriate. It would be better to
> > have a parameter to --ask-password like --ask-password=external or receive
> > the name of the environment variable to use.
> 
> I wanted to use the SSH_ASKPASS variable since this variable is used
> beyond ssh at this point, notably by git.  Although, admittedly after
> checking GIT_ASKPASS and a git config entry first.
> 
> I did not want to add to --ask-password since the username can be
> requested as well and I don't believe this is the case with
> --ask-password.  I also didn't want to affect the existing
> functionality.

How about changing to option to --use-askpass and I will add a check for
WGET_ASKPASS, then fall back to SSH_ASKPASS if WGET_ASKPASS is not set.
This mimics what git does and allows more customization by the user and
removes ssh from the name of the flag.

Thanks,
Liam

> 
> > 
> > Plus I also agree that something like popen would be preferable.
> 
> Do you have a strong preference towards popen over posix_spawn?  Jeremie
> expressed concern of popen and metacharacters in the environment
> variable so I was going to try and use posix_spawn.
> 
> Thanks,
> Liam