Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

[Tim Ruehsen]

Hi Dagobert,

On Tuesday 17 November 2015 15:09:05 Dagobert Michelsen wrote:
> >> Now only one test is failing:
> >>> FAIL: unit-tests
> >> 
> >> How does think unit-test-thing work? I can’t find a log or some debug
> >> output.
> > 
> > For every test you will have .log file in tests/ resp. testenv/.
> > 
> > Have a look into tests/unit-tests.log. You'll see what function/test
> > fails.
> > Post the output of the failing test here.
> 
> I added that to the buildbot-logs to be catched. However, I don’t see an 
error there:
> > [DEBUG] Testing...
> > 
> > RUNNING TEST test_find_key_value...
> > PASSED
> > 
> > RUNNING TEST test_find_key_values...
> > PASSED
> > 
> > RUNNING TEST test_has_key...
> > PASSED
> > 
> > RUNNING TEST test_parse_content_disposition...
> > PASSED
> > 
> > RUNNING TEST test_parse_range_header...
> > PASSED
> > 
> > RUNNING TEST test_subdir_p...
> > PASSED
> > 
> > RUNNING TEST test_dir_matches_p...
> > PASSED
> > 
> > RUNNING TEST test_commands_sorted...
> > PASSED
> > 
> > RUNNING TEST test_cmd_spec_restrict_file_names...
> > PASSED
> > 
> > RUNNING TEST test_path_simplify...
> > PASSED
> > 
> > RUNNING TEST test_append_uri_pathel...
> > PASSED
> > 
> > RUNNING TEST test_are_urls_equal...
> > PASSED
> > 
> > RUNNING TEST test_is_robots_txt_url...
> > PASSED
> > 
> > RUNNING TEST test_hsts_new_entry...
> > PASSED
> > 
> > RUNNING TEST test_hsts_url_rewrite_superdomain...
> > A new entry should've been created
> > Tests run: 15
> > FAIL unit-tests (exit status: 1)
> 
> So which test is failing? test_hsts_url_rewrite_superdomain ?

Yes, the one without PASSED.

> There is no *hsts* in tests/

The unit tests just calls test functions embedded into source files.
test_hsts_url_rewrite_superdomain() can be found in src/hsts.c

Just a guess: there is some issue with file I/O (e.g. the home directory not 
writable). I have to take a look at it.

Regards, Tim