[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH 2/3] Running Wget through gdb in the tests
From: |
Ander Juaristi |
Subject: |
Re: [Bug-wget] [PATCH 2/3] Running Wget through gdb in the tests |
Date: |
Sat, 11 Apr 2015 17:36:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 04/09/2015 11:32 AM, Ander Juaristi wrote:
On 04/09/2015 11:26 AM, Tim Rühsen wrote:
Hi Ander,
attached is a (experimental) patch that allows you to
$ cd tests
$ GDB_TESTS=1 ./Test--spider.px
If you successfully test it, you might also add GDB_TESTS to the python test
suite and send a git-format patch to the list for reviewing.
Regards, Tim
Wow! Sounds good!
I'll review it and get back to you.
As promised, here go the two patches. I haven't changed your Perl patch. I've
tested both test suites and work perfect, altough some tests rely on Wget's
return code to check for failures, and those tests, when run through GDB, claim
to fail incorrectly because GDB's return code is always zero if everything went
OK. However, it's worth noting that this feature should *only* be used during
development, to tackle down specific bugs, etc. One could write a test case for
certain bug and run it through GDB in order to fix it (as I do). Otherwise, a
dedicated web server would have to be set up (e.g. Apache) and write some
server-side CGI to test that bug, which IMO would be tedious. I'll send one
more patch stating this fact in the documentation.
--
Regards,
- AJ
0001-Added-GDB-support-to-Perl-tests.patch
Description: Text Data
0001-Added-support-for-GDB-in-Python-tests.patch
Description: Text Data