Re: [Bug-wget] gethttp cleanup

[Miquel Llobet]

>
> Miquel, I know you were working on gethttp to increase the header size
> to 8kb, if you already have done something, I promise I will rebase your
> patch on top of my series :-)

I wasn't done yet so it's okay :-) Actually with this single cleanup label
idea it should look a lot better, I'd love to work on that.

Miquel Llobet



On Mon, Mar 16, 2015 at 2:18 AM, Giuseppe Scrivano <address@hidden>
wrote:

> Hi,
>
> spring is coming and it is time for some cleanup.
>
> I have refactored a bit gethttp and moved some code to other functions.
> It is mostly mechanical code movements, and I hope to do some more work
> on this (if other people want to jump in, you are welcome!) and simplify
> gethttp even more.  It is still a huge beast, but should be weaker after
> the series below.
>
> I will wait for comments before pushing these patches.
>
> Miquel, I know you were working on gethttp to increase the header size
> to 8kb, if you already have done something, I promise I will rebase your
> patch on top of my series :-)
>
> If some GSoC students want to have something more or less easy to warm
> up, here is an idea: move gethttp to use a single cleanup label at the
> end of the function.  Avoid early exits from gethttp and replace them
> with "goto cleanup", all the cleanups must be done after this point
> (this means local variables must be properly initialized as they could
> be cleaned-up before they were supposed to be).
>
> Cheers,
> Giuseppe
>
>