[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 2
|
From: |
Giuseppe Scrivano |
|
Subject: |
Re: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 256 |
|
Date: |
Sun, 15 Mar 2015 22:42:15 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Miquel Llobet <address@hidden> writes:
> Could this be dinamically allocated?
>
> Indeed it can! Thanks Giuseppe and Darshit for pointing out. Ideally
> we should change all the resp_header_copy calls to resp_header_strdup
> (dynamic resp header copy). There is a bit to code to change, as the
> function returns are different etc. expect a big patch.
since there is a reasonable upperbound value, can't we just have
something like: "char *hdrval = xmalloc(8192);"?
What is left to do is ensure we don't leak this buffer when the function
exits.
Regards,
Giuseppe