Re: [Bug-wget] [Patch] fix bug #44516, -o- log to stdout

[Miquel Llobet]

Yeah, I'll be using git format patch from now on. Do you prefer pasting the
commit on the message or attaching a file?

Best,

Miquel Llobet



On Sun, Mar 15, 2015 at 8:59 PM, Giuseppe Scrivano <address@hidden>
wrote:

> Miquel Llobet <address@hidden> writes:
>
> >     It seems like the correct thing to do. Could you please just use
> >     as
> >     ChangeLog-style like commit message?
> >
> > Yes! Sorry about that, here is the patch with the new commit message.
> > Let me know if this is correct.
> >
> > Fixed #44516 -o- not logging to stdout
> >
> > src/log.c (log_init): check for hypen on filename, set stdout
> >
> > --- src/log.c.origin 2015-03-13 01:32:27.000000000 +0100
> > +++ src/log.c 2015-03-13 01:44:31.000000000 +0100
> > @@ -598,11 +598,18 @@
> > {
> > if (file)
> > {
> > - logfp = fopen (file, appendp ? "a" : "w");
> > - if (!logfp)
> > + if (HYPHENP (file))
> > {
> > - fprintf (stderr, "%s: %s: %s\n", exec_name, file, strerror (errno));
> > - exit (WGET_EXIT_GENERIC_ERROR);
> > + logfp = stdout;
> > + }
> > + else
> > + {
> > + logfp = fopen (file, appendp ? "a" : "w");
> > + if (!logfp)
> > + {
> > + fprintf (stderr, "%s: %s: %s\n", exec_name, file, strerror (errno));
> > + exit (WGET_EXIT_GENERIC_ERROR);
> > + }
> > }
> > }
>
> I think the indentation got screwed here.  Would you send the patch
> attaching what 'git format-patch' gives you or using git send-email?
>
> As the patch doesn't change many lines, we can merge it before waiting
> for the copyright assignments to the FSF.
>
> Thanks,
> Giuseppe
>

0001-Fixed-44516-o-not-logging-to-stdout.patch
Description: Binary data