[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Issue with --content-on-error and --convert-links
From: |
Yousong Zhou |
Subject: |
Re: [Bug-wget] Issue with --content-on-error and --convert-links |
Date: |
Sun, 8 Mar 2015 23:59:15 +0800 |
Hi,
On 31 January 2015 at 10:13, Yousong Zhou <address@hidden> wrote:
>>>> Ah sorry, my fault / misunderstanding.
>>>> Since the patch changes Wget behaviour I would apply it after the next
>>>> bugfix
>>>> release.
>>>> A test case would be perfect. Please consider creating a python test case
>>>> (see
>>>> directory testenv). We will move all test cases from perl to python by the
>>>> time.
>>>>
>>>
>>> Well, there they are, with a few fixes for other issues I encountered
>>> when preparing for this.
>>
>> patches look fine to me, could you please ensure to write the commit
>> message using the ChangeLog format?
>>
>> When it is just one line log, you can just use the format:
>>
>> * blah/file (function): Describe what changed.
>>
>> Otherwise use the format:
>>
>> one short line to describe the change
>>
>> * blah/file1 (foo): Describe what changed here.
>> * blah/file2 (bar): And here.
>>
>> More about the ChangeLog style here:
>>
>> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
>>
>
> Changes are made to
>
> - Follow GNU Changelog style commit message.
> - Update the 2nd patch so that no color codes will be printed when
> the stdout is not a tty-like device.
>
I noticed that wget v1.16.2 has been released. Is it okay that this
series can be reviewed again and applied? FYI, attachments can be
found at link [1]
[1] Re: [Bug-wget] Issue with --content-on-error and --convert-links,
https://lists.gnu.org/archive/html/bug-wget/2015-01/msg00073.html
Regards.
yousong
- Re: [Bug-wget] Issue with --content-on-error and --convert-links,
Yousong Zhou <=