Re: [Bug-wget] Final error on Solaris: libintl missing during "make check"

[Dagobert Michelsen]

Hi Tim,

> Am 22.01.2015 um 12:02 schrieb Tim Ruehsen <address@hidden>:
> 
> Hi Dago,
> 
> could you please send the output of
> 
> $ egrep 'INTL|ICONV' config.log|grep LIB
> 
> (after ./configure ...) ?

Sure:

> address@hidden [unstable10s]:/home/dam/work/wget > egrep 'INTL|ICONV' 
> config.log|grep LIB
> | #define HAVE_LIBINTL_H 1
> ...
> | #define HAVE_LIBINTL_H 1
> GNULIB_ICONV='1'
> INTLLIBS='-lintl'
> INTL_MACOSX_LIBS=''
> LIBICONV='-liconv'
> LIBINTL='-lintl'
> LTLIBICONV='-liconv'
> LTLIBINTL='-lintl'
> #define HAVE_LIBINTL_H 1

It looks like the LIBS setting between src/Makefile and tests/Makefile is 
different and in tests/Makefile
the relevant libs are missing:

src/Makefile:LIBS = -liconv -lintl -L/opt/csw/lib -lpcre   -luuid -lnettle 
-L/opt/csw/lib -lgnutls   -L/opt/csw/lib -lz   -lsocket -lnsl -lrt  -lidn 
$(LIB_CLOCK_GETTIME)
tests/LIBS = -L/opt/csw/lib -lpcre   -luuid -lnettle -L/opt/csw/lib -lgnutls   
-L/opt/csw/lib -lz   -lsocket -lnsl -lrt  -lidn -lintl -liconv

This tiny patch fixes the issue:

> From 2e6f86b9af53a3f04a228305042da5984a0dc04a Mon Sep 17 00:00:00 2001
> From: Dagobert Michelsen <address@hidden>
> Date: Thu, 22 Jan 2015 13:01:29 +0100
> Subject: [PATCH] At least Solaris needs libintl and libiconv for testsuite
> 
> ---
>  tests/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index ae96f5b..9645743 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -33,6 +33,8 @@
>  # Version: @VERSION@
>  #
>  
> +LIBS     = @LIBICONV@ @LIBINTL@ @LIBS@ $(LIB_CLOCK_GETTIME)
> +
>  ../src/wget$(EXEEXT):
>         cd ../src && $(MAKE) $(AM_MAKEFLAGS)
>  
> -- 
> 2.2.1

I have also set up continoue integration on Solaris 10 Sparc and Solaris 10 
i386:
  
https://buildfarm.opencsw.org/buildbot/waterfall?builder=wget-solaris10-i386&builder=wget-solaris10-sparc&reload=300

If useful I can set up notifications when the build breaks.


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to 
do something,
and then doing it so hard that you become great in the process." - xkcd #896

smime.p7s
Description: S/MIME cryptographic signature