Re: [Bug-wget] [PATCH] Fixing C89 warnings

[Tim Rühsen]

Thanks, Gisle.

It is pushed.

> > That's really good news to me. But there are still lots
> > more C99 "errors". Espesially in main.c.

Feel free to send patches.

Sadly, I can't work with -Werror (but use -std=c89 -pedantic -Wall -Wextra + 
more). And I also might oversee warnings because the scrolling is too fast.

Thanks to have a thorough look at current changes.

Tim


Am Mittwoch, 3. Dezember 2014, 13:41:13 schrieb Gisle Vanem:
> > That's really good news to me. But there are still lots
> > more C99 "errors". Espesially in main.c.
> 
> Now another C99 "error" got into openssl.c. Patch:
> 
> --- Git-latest/src/openssl.c    2014-12-03 14:06:19 +0000
> +++ openssl.c   2014-12-03 14:14:37 +0000
> @@ -170,6 +170,7 @@
>   ssl_init (void)
>   {
>     SSL_METHOD const *meth;
> +  long ssl_options = 0;
> 
>   #if OPENSSL_VERSION_NUMBER >= 0x00907000
>     if (ssl_true_initialized == 0)
> @@ -203,8 +204,6 @@
>     SSLeay_add_all_algorithms ();
>     SSLeay_add_ssl_algorithms ();
> 
> -  long ssl_options = 0;
> -
>     switch (opt.secure_protocol)
>       {
>   #ifndef OPENSSL_NO_SSL2
> 
> -----------
> 
> FYI. There are gcc options to trigger an error for these
>    cases. Such as "gcc -Wdeclaration-after-statement -Werror".
>    But there are other harmless warnings.

signature.asc
Description: This is a digitally signed message part.