[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always
From: |
Darshit Shah |
Subject: |
Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false |
Date: |
Fri, 21 Nov 2014 13:56:01 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 11/21, Daniel Stenberg wrote:
Hey
Attached is a tiny patch that fixes a compiler warning as the right
part of the condition always evaluates to true when a signed char is
checked if it is larger than 127.
Some would term this as defensive programming. Though I think if a signed char
were to exceed 127 for any reason, such checks will be the least of the problems
for Wget.
I pushed this patch after adding the required ChangeLog entry. (Another ancient
relic, I want to get rid of)
--
Thanking You,
Darshit Shah
pgpx3ftPWJoIz.pgp
Description: PGP signature
- [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false, Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false, Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false,
Darshit Shah <=
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Darshit Shah, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Jakub Cajka, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Jakub Cajka, 2014/11/21