Re: [Bug-wget] [PATCH] Fixing C89 warnings

[Tim Ruehsen]

Hi Gisle,

please always answer to the mailing list.

You don't have the latest git version, at least your diff isn't based on it.

I pushed the C89 changes right before I asked you to give me the compiler 
output.

I guess MSVC 16 can be used on WinXP while MSVC 18 is for Win7 and up ?

Please redo your diff and check if the errors below still exist (looks like 
size_t is not available !?). If they do, please add your src/config.h.

Tim


On Thursday 20 November 2014 11:14:29 Gisle Vanem wrote:
>   > Please 'git pull' and send the (error/warning) output of MSVC
>   > compilation. I would like to know exactly what it complains about.
> 
> First I've used MSVC v18 with no problem. But the MSVC v16
> has no C99 feature like declaration after code. So in e.g.
> main.c and warc.c there are tons of error like these:
> 
> cl -nologo -MD -O2 -Zi -W3 -I. -Ig:/MingW32/src/gnu/gnulib/lib
> -DENABLE_IPV6 -DENABLE_DEBUG -DENABLE_OPIE -DENABLE_DIGEST
> -DHAVE_LIBZ -DENABLE_WARC -D_WIN32_WINNT=0x0501 -DCTRLBREAK_BACKGND
> -Fo./MSVC_obj/warc.obj -c warc.c
> warc.c
> warc.c(171) : error C2275: 'size_t' : illegal use of this type as an
> expression g:\vc_2010\vc\include\codeanalysis\sourceannotations.h(29) : see
> declaration of 'size_t' warc.c(171) : error C2146: syntax error : missing
> ';' before identifier 'n' warc.c(171) : error C2065: 'n' : undeclared
> identifier
> warc.c(172) : error C2065: 'n' : undeclared identifier
> warc.c(172) : error C2065: 'n' : undeclared identifier
> warc.c(271) : error C2143: syntax error : missing ';' before 'type'
> warc.c(272) : error C2275: 'size_t' : illegal use of this type as an
> expression g:\vc_2010\vc\include\codeanalysis\sourceannotations.h(29) : see
> declaration of 'size_t' warc.c(272) : error C2146: syntax error : missing
> ';' before identifier 's' warc.c(272) : error C2065: 's' : undeclared
> identifier
> warc.c(273) : error C2065: 's' : undeclared identifier
> 
> ----------
> 
> Too many so I was forced to create a fake-warc.c in my Makefile.
> I don't care about WARC either.
> 
> But the rest of my diffs to make it compile with MSVC v16 are
> attached.

signature.asc
Description: This is a digitally signed message part.