Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

[Tim Rühsen]

Am Mittwoch, 29. Oktober 2014, 15:57:04 schrieb Mike Frysinger:
> On 28 Oct 2014 11:47, Tim Ruehsen wrote:
> > I pushed it, since it fixes a bug anyways.
> 
> it still seems to be racy for me -- passes only rarely.  using wget 1.16
> with just the one fix 3eff3ad69a46364475e1f4abdf9412cfa87e3d6c.
> 
> example failure log:
> $ cat Test-proxied-https-auth.log
> --2014-10-29 15:54:50--  https://no.such.domain/needs-auth.txt
> Resolving localhost... ::1, 127.0.0.1
> Connecting to localhost|::1|:51110... failed: Connection refused.
> Connecting to localhost|127.0.0.1|:51110... connected.
> WARNING: cannot verify no.such.domain's certificate, issued by
> ‘/C=US/ST=California/L=Santa Claa/O=Internet Widgits Pty Ltd/CN=Micah
> Cowan/address@hidden: Self-signed certificate encountered.
>     WARNING: certificate common name ‘Micah Cowan’ doesn't match requested
> host name ‘no.such.domain’. Proxy request sent, awaiting response...
> HTTP/1.0 401 Unauthorized Connection: close
> WWW-Authenticate: Basic realm="gondor"
> 
> 401 Unauthorized
> Reusing existing connection to no.such.domain:443.
> Proxy request sent, awaiting response... No data received.
> Retrying.
> 
> --2014-10-29 15:54:51--  (try: 2)  https://no.such.domain/needs-auth.txt
> Got code: 256
> -mike

Hi Mike,

as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with 
GnuTLS does not show any problems.

I investigated today at least 2 hours and found + fixed a few bugs (I will post 
the patches tomorrow). But none of them fixes the flakyness.

Right now it looks like a buffer overflow to me...
Valgrind shows different illegal accesses between the 'success' and the 
'failure' case.

It was the main reason today that prevented to look closer at your patches :-(

The reason why I pushed the patch was fixing a general sync problem between 
parent and child (the tests forks itself to create the server process).

Tim

signature.asc
Description: This is a digitally signed message part.