Re: [Bug-wget] [Bug-Wget][Patch] Implement --show-progress

[Darshit Shah]

Hello,

As Gisle pointed out in the other thread, the progress implementation had a
few flaws. I've mostly ironed them all out in this patch. This is a
slightly enhanced version of the patch I sent on the other thread related
to progress bar implementation.

In a gist, this patch:
1. Cleans up output in case of dot-style progress bar by not printing extra
newlines when not needed
2. Ensures all the columns are perfectly aligned in all (?) cases
3. Makes the filename column fixed width. This makes a much better image
when downloading multiple files in quiet mode.

Please do test this patch and I welcome any and all comments on it.


On Wed, Apr 30, 2014 at 9:39 PM, Giuseppe Scrivano <address@hidden>wrote:

> Darshit Shah <address@hidden> writes:
>
> > No, I haven't tried porting this code into parallel-wget yet. We'd
> > have to edit all the calls to fd_read_body() which I'm assuming have
> > shifted by a large amount so we'll have to manually merge it. This set
> > of patches is for master only.
>
> feel free to push your patch whenever you want :)
>
> Giuseppe
>



-- 
Thanking You,
Darshit Shah

0001-Aesthetic-changes-and-bug-fixes-for-progress-bar.patch
Description: Text Data