[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] add support for SO_MARK: --so-mark
|
From: |
Tim Ruehsen |
|
Subject: |
Re: [Bug-wget] [PATCH] add support for SO_MARK: --so-mark |
|
Date: |
Thu, 30 Jan 2014 10:00:07 +0100 |
|
User-agent: |
KMail/4.11.5 (Linux/3.12-1-amd64; KDE/4.11.5; x86_64; ; ) |
On Wednesday 29 January 2014 17:08:06 Gisle Vanem wrote:
> "Alban Crequy" <address@hidden> wrote:
> > I'm not sure this is a feature that wget would want, but it was uselful to
> > me for testing traffic control.
>
> I'm sure. But you should at least "#ifdef SO_MARK" around that
> code. Winsock doesn't have it.
First @Alban: Thanks for sharing the code on the list !
Not only Winsock doesn't have SO_MARK.
man 7 socket: ... SO_MARK (since Linux 2.6.25) ...
To make the patch complete it requires a bit work on
- src/ChangeLog
- doc/wget.texi
- doc/ChangeLog
- (optional) doc/sample.wgetrc
There are other socket options that someone could use (SO_BINDTODEVICE,
SO_PRIORITY, SO_KEEPALIVE, ...).
Maybe a more general command line option makes sense ?
Like
--socket-options=option[=value][,option[=value]]...
e.g.
--socket-options=SO_MARK=1,SO_PRIORITY=3,SO_BINDTODEVICE=eth1
Tim