[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Fail
From: |
Darshit Shah |
Subject: |
Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures. |
Date: |
Tue, 16 Jul 2013 20:52:01 +0530 |
Attaching a patch that fixes the above stated issue.
There are two regions that I would like to draw attention to:
1. http.c:3752 : The code is quite redundant and I would prefer that it was
somehow merged. Ideas on fixing this would be greatly appreciated!
2. http.c:2424 : There is a simple if-else statement here. I initially had
a ternary statement here like:
return AUTHFAILED?(auth_err == RETROK):auth_err;
However, instead of returning AUTHFAILED when auth_err is RETROK, the
function keeps returning NOCONNERROR. I am unable to understand why this
happens. Can anyone please explain?
--
Thanking You,
Darshit Shah
0001-Fix-Exit-Status-Codes-when-there-are-errors-in-Diges.patch
Description: Binary data
- [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Tim Rühsen, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Daniel Stenberg, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/14
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Tim Rühsen, 2013/07/15
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures.,
Darshit Shah <=
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Tim Rühsen, 2013/07/16
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/17
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Tim Rühsen, 2013/07/18
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Giuseppe Scrivano, 2013/07/21
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/22
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Giuseppe Scrivano, 2013/07/22
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/22
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Darshit Shah, 2013/07/22
- Re: [Bug-wget] [Bug-Wget] Wrong Error Codes returned on Digest Auth Failures., Giuseppe Scrivano, 2013/07/22