Re: [Bug-wget] Big refactoring

[Jeremy Nicoll - ml wget users]

illusionoflife <address@hidden> wrote:

> Okay. I would like to hear more opinions. Because for me, two-line loop
> and comment before is worse then function with speaking name. 3 lines vs
> 1.

The loop and comment looks to me like a pretty standard C idiom, to the
point where the comment is nearly inessential (but I prefer to see such
comments).  

On the other hand, while the function name is great, I agree with the
previous poster who said that until you actually look at the function
definition you can't be sure that it has an accurate name (eg that no-one
has added any extra feature that are not described in the name).  

So I prefer the loop because you can see at a glance that it does do
precisely what the comment says.

The number of lines in the file is irrelevant; clarity is what matters.

-- 
Jeremy C B Nicoll - my opinions are my own.