Re: [Bug-wget] need some advice for 0 timeout code

[Hrvoje Niksic]

Tim Ruehsen <address@hidden> writes:

> Am Tuesday 15 May 2012 schrieb Hrvoje Niksic:
>> Tim Ruehsen <address@hidden> writes:
>> > There are three obvious ways to fix the issue once and for all:
>> > a)
>> > when given the timeout value 0, use INFINITY and special handle this
>> > value in select_fd() to call select with timeout NULL.
>> 
>> Why call select() or select_fd() at all when timeout is 0?
>
> Some parts in the source call select_fd() with timeout==0, supposed to return 
> immediately with -1, 0 or 1.

And that's fine.  What I meant is: there is no need to even bother to
call select_fd() in the case when the intended timeout is supposed to be
infinite.

> Changing select_fd() simply won't work.

Agreed - however, I'm not proposing to change select_fd(), but its
callers.  Wget code base has changed considerably since I last worked on
it, so I could easily be missing something.