Re: [Bug-wget] [PATCH] [wget-bug #32357], IPv6 addresses not formatted..

[Sasikanth]

I had modified the patch as you guys suggested.
For ipv6 the display will be [ipv6address]:port
for ipv4   ipv4address:port

The test results

IPv4
-------

address@hidden wget-1.13.4]# ./src/wget http://10.0.0.1
--2012-01-07 11:01:23--  http://10.0.0.1/
Connecting to 10.0.0.1:80...

IPv6
-------
address@hidden wget-1.13.4]# ./src/wget http://[3ffe:b80:17e2::1]
--2012-01-07 11:01:06--  http://[3ffe:b80:17e2::1]/
Connecting to [3ffe:b80:17e2::1]:80

Thanks
Sasi

On Sat, Jan 7, 2012 at 3:14 AM, Henrik Holst
<address@hidden>wrote:

> Exactly! That is how atleast I have akways seen address and port
> combinations been presented (or entered).
>
> /hh
> Den 6 jan 2012 21:27 skrev "Micah Cowan" <address@hidden>:
>
> I believe hh's suggestion is to have the format reflect the way it would
>> look in a URL; so [ and ] around ipv6, and nothing around ipv4 (since ipv4
>> format isn't ambiguous in the way ipv6 is).
>>
>> (Sent by my Kindle Fire)
>> -mjc
>> Sent from my Kindle Fire
>>
>> ------------------------------
>> *From:* Sasikanth <address@hidden>
>> *Sent:* Fri Jan 06 01:56:34 PST 2012
>> *To:* address@hidden
>> *Cc:* address@hidden
>> *Subject:* Re: [Bug-wget] [PATCH] [wget-bug #32357], IPv6 addresses not
>> formatted..
>>
>> Currently we are not checking family type of the address before printing
>> the message.
>>
>> Do we have to print the message as [3ffe:b80:17e2::1]:80 for ipv6 and
>>
>> |10.0.0.1|:80 for ipv4?
>>
>> Please confirm so I will resubmit patch.
>>
>> Thanks
>> Sasi
>>
>>
>> Note: I didn't get the reply to my mail, to keep track the discussion I
>>
>> had copied the mail content from the mailing list.
>>
>> Shouldn't IPv6 addresses be displayed like this instead:
>> [3ffe:b80:17e2::1]:80
>>
>> /hh
>> Den 5 jan 2012 14:15 skrev "Sasikanth" <address@hidden>:
>>
>> >  Hi,
>> >
>> >  This very small change related to display issue.
>> >  The  bug id is 32357
>> "https://savannah.gnu.org/bugs/index.php?32357";;
>>
>> >
>> >  When we run wget
>>   with
>> an ip address alone  (wget 10.0.0.1 or wget
>> > http://10.0.0.1/ or wget http://[3ffe:b80:17e2::1])
>> >  the display shows as
>>
>> >
>> >  IPV4
>> >  Connecting to 10.0.0.1:80...
>> >  IPV6
>> >  Connecting to 3ffe:b80:17e2::1:80   (Because of IPV6 format (ff::01)
>> it is
>> > little hard differentiate the ipv6 address and port number)
>>
>> >
>> >  This patch will show the display
>> >
>> >  IPV4
>> >  Connecting to |10.0.0.1|:80...
>> >  IPV6
>> >  Connecting to |3ffe:b80:17e2::1|:80
>> >
>>
>> >
>> > Thanks
>> > Sasi
>>
>>

patch_bug32357.txt
Description: Text document