[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] set exit code to 1 if invalid host name specified
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [PATCH] set exit code to 1 if invalid host name specified |
Date: |
Sat, 23 Apr 2011 16:45:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Thanks for the patch. It looks ok but in order to apply it, you need to
complete the copyright assignments process to the FSF. We are very
quite close to have a wget release and I doubt the FSF will receive your
assignments before it. Can you please divide your patch in two? Keep
changes to the source code in one patch and the new tests in another.
Please keep the GNU coding style:
Daniel Manrique <address@hidden> writes:
> === modified file 'src/html-url.c'
> --- src/html-url.c 2011-01-01 12:19:37 +0000
> +++ src/html-url.c 2011-04-23 00:48:22 +0000
> @@ -810,6 +810,7 @@
> file, url_text, error);
> xfree (url_text);
> xfree (error);
> + inform_exit_status(URLERROR);
Please maintain the GNU coding style:
inform_exit_status (URLERROR);
Cheers,
Giuseppe