Re: [Bug-wget] timestamping and continue don't play nice with each other

[Giuseppe Scrivano]

Caleb,

Caleb Cushing <address@hidden> writes:

> I thought it was working because sometimes I seemed to get the files
> updated but the last couple of days no updates came in, so I turned
> continue off and by timestamp check alone it downloaded new files. So
> I guess it must not work all the time :( or something else is going
> 

I have fixed another case of -N and -c not working well together.  I am
going to push this patch.


Thanks,
Giuseppe


=== modified file 'src/http.c'
--- src/http.c  2010-07-11 13:47:18 +0000
+++ src/http.c  2010-07-18 17:50:23 +0000
@@ -1645,7 +1645,7 @@
   request_set_header (req, "Referer", (char *) hs->referer, rel_none);
   if (*dt & SEND_NOCACHE)
     request_set_header (req, "Pragma", "no-cache", rel_none);
-  if (hs->restval)
+  if (hs->restval && !opt.timestamping)
     request_set_header (req, "Range",
                         aprintf ("bytes=%s-",
                                  number_to_static_string (hs->restval)),
@@ -2376,9 +2376,8 @@
     }
 
   if (statcode == HTTP_STATUS_RANGE_NOT_SATISFIABLE
-      || (hs->restval > 0 && statcode == HTTP_STATUS_OK
-          && contrange == 0 && hs->restval >= contlen)
-     )
+      || (!opt.timestamping && hs->restval > 0 && statcode == HTTP_STATUS_OK
+          && contrange == 0 && hs->restval >= contlen))
     {
       /* If `-c' is in use and the file has been fully downloaded (or
          the remote file has shrunk), Wget effectively requests bytes