Re: [PATCH] Silence compiler warnings with MinGW64

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: GavinSmith0123@gmail.com,  bug-texinfo@gnu.org
> Date: Thu, 06 Apr 2023 14:18:50 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Why on Earth is a system header included only in msys2-runtime-devel?
> >
> > Also, is msys2-runtime-devel about building MSYS2 programs or MinGW
> > programs?  If the latter, it shouldn't be needed for your attempts to
> > build a MinGW port.
> 
> Sorry, I can't tell if msys2-runtime-devel is about building MSYS2
> programs or MinGW programs.  The package info is: MSYS2 headers and
> libraries.  I simply did
> 
>   pkgfile -s wait.h
> 
> which returned
> 
>   mingw64/mingw-w64-x86_64-arm-none-eabi-newlib
>   mingw64/mingw-w64-x86_64-postgresql
>   mingw64/mingw-w64-x86_64-python-autopxd2
>   mingw64/mingw-w64-x86_64-riscv64-unknown-elf-newlib
>   msys/msys2-runtime-3.3-devel
>   msys/msys2-runtime-devel
> 
> and took the package which looked sensible to me.

Hmm... MinGW build shouldn't need wait.h, it's a header that is not
present on Windows.  The packages you show above are either not
relevant to building MinGW programs to run them natively on Windows,
or are for MSYS2 development.  If you use such a wait.h, you could get
in trouble.

Texinfo 7.0.3 doesn't have any inclusions of wait.h, only sys/wait.h,
in Gnulib's stdlib.h and in in man.c.  The latter is guarded by
"#if defined (HAVE_SYS_WAIT_H)", and the former should not be used
on MinGW.  What problems do you get if wait.h is not available?

Btw, I just built Texinfo 7.0.3, and info.exe still displays Unicode
quotes as I expect: transliterated to ASCII characters.  So why it
doesn't work for your build on your system is still a mystery to me.