[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] HTML: Enable generating copiable anchors on heading comma
From: |
Patrice Dumas |
Subject: |
Re: [PATCH v2] HTML: Enable generating copiable anchors on heading commands |
Date: |
Thu, 26 Jan 2023 20:32:21 +0100 |
On Thu, Jan 26, 2023 at 01:45:00PM +0100, Arsen Arsenović wrote:
> * doc/texi2any_api.texi (Basic Formatting Customization): Document
> the new $target argument of format_heading_
> * tp/Texinfo/Convert/HTML.pm (_default_format_heading_text): Add
> optional target argument, for generating a copiable pilcrow.
> (_convert_heading_command): Pass the element_id of the current
> heading, so that a pilcrow is generated.
> * tp/tests/customization/list-of-tests: Add
> sectioning_without_anchors test, to check getting existing codegen
> with COPIABLE_LINKS=0.
> ---
> Hi Patrice,
>
> Yes, you're right. I missed the $id argument entirely in my original
> pass. I've added that now. I also updated the internals documentation
> in this revision.
For the documentation, I prefer to separate the description of the API
to the description of the default result. Indeed, the users can
redefine the function reference, so I think that it is good to explain
the input and output independently of the default implementation.
I'll do a change.
Also you did not regerenerate the t/*.t results, I'll do it.
Lastly, for consistency, I think that it is better to use only " for the
attributes, I can do it too.
--
Pat
Re: [PATCH] HTML: Enable generating copiable anchors on heading commands, Gavin Smith, 2023/01/26