Re: Release branch added to git

[Patrice Dumas]

On Sat, Nov 12, 2022 at 11:53:19PM +0100, Patrice Dumas wrote:
> On Sat, Nov 12, 2022 at 10:26:54PM +0000, Gavin Smith wrote:
> > 
> > Commit 15ef3457ed1 (on release branch)
> > 
> > This led to test result changes in
> > tp/t/results/sectioning/unnumbered_before_top_node.pl
> > tp/t/results/preformatted/titlefont_in_example.pl
> > 
> > which weren't on the master branch - in both cases, the title from
> > @titlefont was lost, although @titlefont was used in an unusual context.
> > I assume this doesn't matter but please let me know if it does.
> 
> It looks like a bug, 
> @@ -9916,6 +9927,7 @@ sub output($$)
>    if (!$fulltitle and $self->{'global_commands'}->{'titlefont'}
>        and $self->{'global_commands'}->{'titlefont'}->[0]->{'args'}
>        and 
> defined($self->{'global_commands'}->{'titlefont'}->[0]->{'args'}->[0])
> +      and $self->{'global_commands'}->{'titlefont'}->[0]->{'contents'}
>        and 
> @{$self->{'global_commands'}->{'titlefont'}->[0]->{'args'}->[0]->{'contents'}})
>  {
>      $fulltitle = $self->{'global_commands'}->{'titlefont'}->[0];
>    }
> 
> should be 
>        and 
> $self->{'global_commands'}->{'titlefont'}->[0]->{'args'}->[0]->{'contents'}

Actually it is in
https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=40ec4f80ba9875cb801390bf7a2fed4371c6c4dc

So the line
                                                ->{'args'}->[0]->{'contents'}
should be added in a separate commit.

-- 
Pat