Re: libintl glitches in XS

[Gavin Smith]

On Tue, Apr 09, 2019 at 11:47:26PM +0200, Hans-Bernhard Bröker wrote:
> Hello one and all,
> 
> after running into failures on Cygwin for a while, I decided to
> investigate a bit deeper to see what was keeping things from working,
> and found a few suspicious aspects.

Thanks for the report.  There were no reports of people trying to run on 
Cygwin lately.

> *) I had to add $(LIBINTL) to Parsetexi_la_LIBADD, or it wouldn't manage
> to build Parsetexi.la.  This may be partly due to Cygwin's variant of
> shared library, unlike the Linux kind, requiring to be fully covered,
> i.e. they cannot have undefined references inside.  It feels like
> something similar should be done with $(LTLIBINTL) and $(LIBICONV), too.
>  Either that, or $(LTLIBICONF) should be in ..._LIBADD, not ..._LDFLAGS.

Is this with Texinfo 6.6 or the current git development?  I expect the 
latter as libintl is gettext, which Parsetexi.la only started using 
recently.

I see in tp/Texinfo/XS/Makefile.am, $(LIBINTL) is in XSParagraph_la_LIBADD
so it would make sense to have it in Parsetexi_la_LIBADD too.  (Although 
XSParagraph.la doesn't use gettext, so maybe it is needed for something 
else.)  Is that the only change you needed to make it work?

The "undefined references" issue is supposed to be taken care of in 
Makefile.am under the HOST_NEEDS_NO_UNDEFINED section.

> *) I'm seeing quite a few `$p' in Makefile.am.  I'm pretty sure these
> really should be `$(p)' instead.

If the brackets are missing the first character after the $ is taken as 
the variable name.