bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor build fixes


From: Eli Zaretskii
Subject: Re: Minor build fixes
Date: Fri, 03 Oct 2014 09:26:27 +0300

> Date: Thu, 02 Oct 2014 18:24:49 -0400
> From: Ken Brown <address@hidden>
> Cc: Texinfo <address@hidden>
> 
> >> -#ifdef GWINSZ_IN_SYS_IOCTL
> >> +#ifndef __MINGW32__
> >>   #  include <sys/ioctl.h>
> >>   #endif
> >>
> >
> > I see the same thing (conditional on __MINGW32__) is done when
> > including sys/ioctl.h in info/ioctl.h and info/man.h. It looks like
> > GWINSZ_IN_SYS_IOCTL is set by the AC_HEADER_TIOCGWINSZ macro in
> > configure.ac. However, your patch is probably what we want because
> > we're not just including <sys/ioctl.h> to get TIOCGWINSZ (although I
> > don't understand why you would want the definition of TIOCGWINSZ and
> > /not/ have the definition of ioctl, so maybe I'm missing something?)
> 
> I don't understand that either.

At least info/session.c uses the ioctl function itself, for the
FIONREAD command, so the condition could be computed at configure
time.

Not sure why man.c needs ioctl.h, but an easy way to find out is
remove that line and see if Info still compiles.  Maybe it's not
needed at all.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]