bug-standards
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Script to generate ChangeLogs automatically


From: Alfred M. Szmidt
Subject: Re: Script to generate ChangeLogs automatically
Date: Fri, 30 Nov 2018 18:06:17 -0500

Tried playing with this just a bit, and please don't get the wrong
idea with all the "it doesn't work complaints".  I think this is an
amazing attempt at automating ChangeLogs.

But I'm a bit confundled, I tried this on one change in the glibc tree
(see below).  While it is true that _itoa.h was included, it isn't
really a function so it shouldn't be listed as such.

The "Modified." comment seems to be redundant, since <_itoa.h> is
included it is by definition that elf/dl-exception.c was modified so
this should at least be "elf/dl-exception.c (_itoa.h): New.".

I also tried running it on two recent commit on the Emacs tree, that
got it confunlded quite badly; and produced ~740 lines of output.
With some really weird results...  Maybe I ran it incorrectly?

For the format, would it make sense to maybe change it to put the hash
in the header instead of a "COMMIT:" "thing"?  Maybe one could extend
the format a bit to suggest this if it makes good sense.



Emacs:
~/emacs/src $ python3 ~/gen-changed-entities.py 
f1ea2b9e6b63593f5919f60a68a9e19026756ac4 
0e484c66fd63877230c3dfa97f2ce9dda71ad88b
[...]
        [_REGEX_RE_COMP ||  
_LIBC][_LIBC][_LIBC][RE_ENABLE_I18N][RE_ENABLE_I18N][RE_ENABLE_I18N][! 
_LIBC][RE_ENABLE_I18N][!(RE_ENABLE_I18N)][!(RE_ENABLE_I18N)][! 
_LIBC][!(RE_ENABLE_I18N)][_LIBC][RE_ENABLE_I18N][!(RE_ENABLE_I18N)][_LIBC][!(RE_ENABLE_I18N)][RE_ENABLE_I18N](if):
 Modified.

[... and a bunch of what seems to be unrelated changes and files?]

The singleton change is:

commit 0e484c66fd63877230c3dfa97f2ce9dda71ad88b (HEAD -> master, origin/master, 
origin/HEAD)
Author: Gemini Lasswell <address@hidden>
Date:   Sun Oct 14 12:12:04 2018 -0700

    Keep a stack reference to bytecode objects being executed (Bug#33014)
    
    * src/eval.c (Ffuncall): Make local variable 'fun' volatile.
    * test/src/eval-tests.el
    (eval-tests-byte-code-being-evaluated-is-protected-from-gc):
    Add regression test for Bug#33014.
    (eval-tests-33014-var): New variable.
    (eval-tests-33014-func, eval-tests-33014-redefine): New functions.



Glibc:
~/glibc $ python3 ../gen-changed-entities.py 
c6a5bdc18979c09c7a2a9cf23fff8ac5781962ae 
ce7387cc250a408d3fbb7a6fff7ad4d977166b00
2018-11-29  H.J. Lu  <address@hidden>

        COMMIT: ce7387cc250a408d3fbb7a6fff7ad4d977166b00
        * elf/dl-exception.c: Modified.
        (_itoa.h): New.

The singleton change is:

commit ce7387cc250a408d3fbb7a6fff7ad4d977166b00
Author: H.J. Lu <address@hidden>
Date:   Thu Nov 29 20:03:46 2018 -0800

    elf/dl-exception.c: Include <_itoa.h> for _itoa prototype
    
    Tested with build-many-glibcs.py.
    
            * elf/dl-exception.c: Include <_itoa.h>.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]