bug-standards
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: standards for info install


From: Karl Berry
Subject: Re: standards for info install
Date: Thu, 18 Feb 2010 23:05:24 GMT

    rw> Missing `; \' at the end so that $$d is still defined in the
    following $(INSTALL_DATA) line.

Right, thanks.  I knew I was missing something.

    Why is this command prefixed with a hyphen (causing errors to be

I suspect it was working around ancient shell craziness where failing
if's always returned false.  Changed.

    FWIW, I'd quote $(DESTDIR)$(infodir) so that spaces are allowed,

Yep, may as well.  Seems like $(srcdir) should be quoted too, as long as
we're being paranoid about it.

Thanks,
Karl


do-install-info: foo.info
        $(NORMAL_INSTALL)
# Prefer an info file in . to one in srcdir.
        if test -f foo.info; then d=.; \
         else d="$(srcdir)"; fi; \
        $(INSTALL_DATA) $$d/foo.info \
          "$(DESTDIR)$(infodir)/foo.info"
# Run install-info only if it exists.
# Use `if' instead of just prepending `-' to the
# line so we notice real errors from install-info.
# Use `$(SHELL) -c' because some shells do not
# fail gracefully when there is an unknown command.
        $(POST_INSTALL)
        if $(SHELL) -c 'install-info --version' \
           >/dev/null 2>&1; then \
          install-info --dir-file="$(DESTDIR)$(infodir)/dir" \
                       "$(DESTDIR)$(infodir)/foo.info"; \
        else true; fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]