[bug-sourceinstall] Re: GNU Source Installer help

[Claudio Fontana]

Hello Steve,
I am moving the conversation to
address@hidden . Please remember to CC: the
list for all further discussions.

--- Stephen Peters <address@hidden> wrote:

> I took a look at the existing code, and
> found the problem with your timeout:  
> catch {package require TK }
> and catch {package require TK }

catch { package require Tk }
catch { package require Expect }

Thank you for providing some light in this.

catch { package require Expect }
initializes the global timeout variable to a value of
10, without caring whether it has been already defined
or not.

> reset global variables.  Why?  I don't know.
> You can either move those lines to the top, or put
> the timeout declaration
> at hte bottom before
> you cann sourceinstaller.

I'll keep the global variable for documentation
purposes, put in a comment, restore the value after
package require and then set the timeout to -1 in each
proc, so no one ever reusing some or all the code can
ever fall in this trap.

> Also, what is the CVSROOT that I should be using,
> and/or is there a good doc on that on Savanaah...

http://savannah.gnu.org/cvs/?group=sourceinstall

Thanks for the catch!

Claudio




                
____________________________________________________ 
Yahoo! Sports 
Rekindle the Rivalries. Sign up for Fantasy Football 
http://football.fantasysports.yahoo.com