bug-recutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-recutils] Python bindings - additions


From: Maninya M
Subject: Re: [bug-recutils] Python bindings - additions
Date: Wed, 18 Sep 2013 18:44:31 +0530

Hi Jose

> - My overall impression is very good :)
Thanks! :)

> - You are including <recutl.h> in python/recutils.c.  recutl.h is a
>   non-published internal header, so that is not a very good idea.
>   Fortunately looks like you are not using it, so lets just remove that
>   include.

Sorry, I had thought I could use it before and forgot to remove it.
Removed it now.

> - Why would you need setters for fields/records "char-locations"?

These are being used in the parser only, will be unnecessary
otherwise. I was not sure when I wrote it. I have removed it.

> - Please move the test stuff (including the test recfiles) from python/
>   to torture/python.
>
> - Please make sure that 'make syntax-check' is happy with your .c files.

Done.

I am writing the documentation, was able to generate texinfo files.
Will upload a draft by today/tomorrow.
Thanks.

On 17 September 2013 22:06, Jose E. Marchesi <address@hidden> wrote:
>
> Hi Maninya.
>
> Some comments about the python bindings.
>
> - My overall impression is very good :)
>
> - You are including <recutl.h> in python/recutils.c.  recutl.h is a
>   non-published internal header, so that is not a very good idea.
>   Fortunately looks like you are not using it, so lets just remove that
>   include.
>
> - Why would you need setters for fields/records "char-locations"?
>
> - Please move the test stuff (including the test recfiles) from python/
>   to torture/python.
>
> - Please make sure that 'make syntax-check' is happy with your .c files.
>
> Thanks.



-- 
Maninya



reply via email to

[Prev in Thread] Current Thread [Next in Thread]