[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-recutils] Python bindings - additions

From: Jose E. Marchesi
Subject: Re: [bug-recutils] Python bindings - additions
Date: Tue, 17 Sep 2013 18:36:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Hi Maninya.

Some comments about the python bindings.

- My overall impression is very good :)

- You are including <recutl.h> in python/recutils.c.  recutl.h is a
  non-published internal header, so that is not a very good idea.
  Fortunately looks like you are not using it, so lets just remove that

- Why would you need setters for fields/records "char-locations"?

- Please move the test stuff (including the test recfiles) from python/
  to torture/python.

- Please make sure that 'make syntax-check' is happy with your .c files.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]