[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-recutils] [PATCH] src: always provide encryption routines and t

From: Jose E. Marchesi
Subject: Re: [bug-recutils] [PATCH] src: always provide encryption routines and their prototypes.
Date: Tue, 27 Mar 2012 19:51:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

    this patch solves two problems: --disable-encryption changed the librec
    ABI, and rec.h wouldn't have declared encryption routines without
    config.h being included before.

    With the patch rec-crypt.c has warnings for unused parameters when
    encryption is disabled, I'm not sure if or how this should be

I would prefer a different solution that would make it easier to
maintain rec-crypt.c: to add a new file rec-crypt-dummy.c which would
just provide the dummy functions.  Then Makefile.am will use rec-crypt.c
or rec-crypt-dummy.c depending on whether encryption support is being
compiled in the library.

What do you think?
Jose E. Marchesi         http://www.jemarch.net
GNU Project              http://www.gnu.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]